[ 
https://issues.apache.org/jira/browse/PROTON-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935155#comment-14935155
 ] 

Gordon Sim commented on PROTON-1004:
------------------------------------

There are two quite different modes of use for the 
create_sender/create_receiver methods, as documented in pydoc. In one you give 
a connection object and the actual target/source address. In the other you give 
a url from which a connection is created and the actual target/source is 
inferred. So the behaviour is as intended. If in the first form you treated the 
target as a url to be parse, it would make it more awkward to attach to a 
target in the url syntax (e.g. with activemq, topics might be identified as 
topic://my-topic).

Whether having the two modes is worth the confusion is I think subject to 
debate. I'm also open to ways of making it nicer overall. However I don't think 
simply trying to parse the exact target when using that mode is the correct 
approach.

> Inconsistency in container.create_sender
> ----------------------------------------
>
>                 Key: PROTON-1004
>                 URL: https://issues.apache.org/jira/browse/PROTON-1004
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding
>    Affects Versions: 0.10
>            Reporter: Ted Ross
>            Assignee: Gordon Sim
>
> For URL = "localhost:5672/examples"
> Using the API in two different ways:
> {noformat}
>     def on_start(self, event):
>         event.container.create_sender(URL)
> {noformat}
> Yields an attach with the following target:
> [address="examples", durable=0, timeout=0, dynamic=false]
> But this variation yields something different:
> {noformat}
>     def on_start(self, event):
>         conn = event.container.connect(URL, heartbeat=8)
>         event.container.create_sender(conn, URL)
> {noformat}
> yields:
> [address="localhost:5672/examples", durable=0, timeout=0, dynamic=false]
> The attach targets should be consistent across these examples.  I believe the 
> first example is the correct one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to