ASF GitHub Bot commented on PROTON-1096:

Github user gemmellr commented on the pull request:

    Hi Sreeram,
    I have made some changes that should let you do what you want. They change 
the API a little by usling a long to make it more intuitive (the message-format 
field is an unsigned int) and also implement the incoming side so that 
[proton-j] recievers can inspect the value should it have been adjusted.
    As an aside, some hints/tips regarding the Apache<->GitHub integration:
    If you create a JIRA before the pull request and include the JIRA key in 
the PR title then a bot will update the JIRA with notice of creation of the PR, 
and also seperately for any comments made on the PR.
    If you also include the JIRA key in any commits, then if they are merged 
as-is their details will be added as a comment on JIRA when pushed to the ASF 
repo, helping keep the details together for later reference.
    For example, see #6 and its associated JIRA PROTON 814 (missed out the dash 
to avoid it being updated).
    (mentioning PROTON-1096 here to have the bot update it too)

> [proton-j] enable set/get of MessageFormat on the Delivery being 
> sent/received 
> -------------------------------------------------------------------------------
>                 Key: PROTON-1096
>                 URL: https://issues.apache.org/jira/browse/PROTON-1096
>             Project: Qpid Proton
>          Issue Type: New Feature
>          Components: proton-j
>    Affects Versions: 0.12.0
>            Reporter: Sreeram Garlapati
>            Assignee: Robbie Gemmell
>             Fix For: 0.12.0
>   Original Estimate: 4h
>  Remaining Estimate: 4h
> This is a feature request from windows azure eventhubs team. Here's the pull 
> request: https://github.com/apache/qpid-proton/pull/53
> I (sreeram, from windows azure eventHubs team) am building eventHubs Java 
> client SDK and taking a dependency on proton-j (which will be available on 
> GitHub, hopefully, soon) for Amqp.
> EventHubs amqp client will need to set a Custom MessageFormat to enable a 
> Critical scenario for Sending (Send Batch) messages to EventHubs from our 
> JavaClient.
> Delivery class, currently, already has a getMessageFormat().. I extended this 
> to also have setMessageFormat() method which should be copied to the Transfer 
> frame.

This message was sent by Atlassian JIRA

Reply via email to