ASF GitHub Bot commented on PROTON-1088:

Github user ganeshmurthy commented on the pull request:

     AppVeyor CI build is failing all SSL tests which has been happening even 
before this pull request. For example, look at 

> Add convenience functions to obtain the client certificate fingerprint, 
> subject subfields
> -----------------------------------------------------------------------------------------
>                 Key: PROTON-1088
>                 URL: https://issues.apache.org/jira/browse/PROTON-1088
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-c
>    Affects Versions: 0.11.1
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>             Fix For: 0.12.0
> 1. Provide a convenience function which will return a an ssl certificate 
> fingerprint (a sha1 or sha256 hash of the certificate). 
> -- When you look go to a https site via a web browser, you can look at the 
> certificate fingerprint by clicking the View Certificate button on the 
> browser. Add a convenience function to proton which will return the char 
> array of octets. sha1 hashing produces a 20 octet hash and sha256 provides a 
> 32 octet hash. The function signature should approximately look like this - 
> void pn_ssl_get_fingerprint(pn_ssl_t \*ssl0, unsigned char \*md, const char* 
> digest_name)
> 2. The subject field on the SSL cert has many subfields like - 
> C = ISO3166 two character country code
> ST = state or province
> L = Locality; generally means city
> O = Organization - Company Name
> OU = Organization Unit - division or unit
> CN = CommonName - end entity name e.g. www.example.com
> Provide convenience functions to obtain values of the above subfields.

This message was sent by Atlassian JIRA

Reply via email to