[ 
https://issues.apache.org/jira/browse/PROTON-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128592#comment-15128592
 ] 

Andrew Stitcher commented on PROTON-515:
----------------------------------------

I have difficulty believing that OpenVMS doesn't have the pipe call.

Ah, I see from your stackoverflow question 
(http://stackoverflow.com/questions/32268232/c-poll-pipe-incompatibility-on-openvms)
 that it's somehow to do with receiving ENOTSOCK - are you sure that is coming 
from poll() rather than recv()? If it is from recv then we should be more 
careful to read it with read().

In any case if you really need to replace that io code then you need a new file 
as this code does not support posix anymore so the existing io.c is not the 
place for this change.

I would suggest splitting out pn_pipe() into its own file .../posix/pipe.c and 
creating a new file .../openvms/pipe.c and then compiling .../openvms/pipe.c 
instead of .../posix/pipe.c on openvms. You will need a change to the CMake 
file as well to do this.

The patch for object.c is bad code as it does not guarantee that the new handle 
will actually be unique in the process.
Can you explain why the original code didn't work - it only uses C89 features 
of the preprocessor - there is nothing non portable about it.

> Port to OpenVMS
> ---------------
>
>                 Key: PROTON-515
>                 URL: https://issues.apache.org/jira/browse/PROTON-515
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-c
>    Affects Versions: 0.11.1
>         Environment: OpenVMS
>            Reporter: Tomas Soltys
>              Labels: OpenVMS, patch
>         Attachments: io.c.patch, object.h.patch
>
>
> There is a need for proton-c port to OpenVMS platform.
> To make proton-c functional on OpenVMS few changes in the source code are 
> required.
> Here is list of files I have identified which require some attention:
> proton-c/src/platform_fmt.h
> proton-c/src/posix/driver.c
> proton-c/src/object/object.c
> proton-c/src/codec/codec.c



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to