Andrew Stitcher commented on PROTON-1136:

I've now checked in a fix for the related JIRA PROTON-1135. So proton-c no 
longer generates pipelined SASL and AMQP frames.
I have modified the python based tests to carry on testing that the proton 
implementation accepts pipelined SASL and AMQP frames. However due to this bug 
Proton-J would fail this test, so I've disabled it for testing Proton-J (as it 
isn't a regression).

The test is proton_tests.sasl.SaslTest.testPipelinedClient  currently this is 
disabled on line 107 of tests/python/proton_tests/sasl.py. When this bug if 
fixed this test should be enabled for Java.

> [proton-j] handle the case when pipelined SASL and OPEN frames are sent for 
> -------------------------------------------------------------------------------------------
>                 Key: PROTON-1136
>                 URL: https://issues.apache.org/jira/browse/PROTON-1136
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-j
>    Affects Versions: 0.12.0
>            Reporter: Ganesh Murthy
> Currently Proton-J is unable to handle pipelined SASL and OPEN frames for 
> ANONYMOUS logins, which are currently sent by proton-c, e.g see the below 
> trace log from Dispatch connecting out using ANONYMOUS:
> {code}
> [0x7f41f80079c0]:  -> SASL
> [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, 
> initial-response=b"anonymous@localhost.localdomain"]
> [0x7f41f80079c0]:  -> AMQP
> [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A", 
> max-frame-size=65536, channel-max=32767, idle-time-out=8000, 
> offered-capabilities=:"ANONYMOUS-RELAY", 
> properties={:product="qpid-dispatch-router", :version="0.6.0"}]
> [0x7f41f80079c0]:  <- SASL
> [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS]
> [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0]
> [0x7f41f80079c0]:  <- AMQP
> {code}
> Given that there are various clients using proton that might do this by 
> default (PROTON-1135 raised regarding that), proton-j should be updated to 
> cope with it.

This message was sent by Atlassian JIRA

Reply via email to