Hi.

I'm just looking at a recent git checkout of prototype.

Having rake dist'd it, I then diff it against my copy which has some
patches that I've submitted a while back to trac.

I noticed that a few tabs have crept in (dom.js, event.js and string.js)

I don't know what the coding styles are, but there are also blank
lines with spaces only. These are removed by rake dist, so maybe not
important.

But what I did spot was in selector.js, lines 656-667.

There are duplicate operators.

I think lines 662 and 663 should be removed.

2 patches supplied (srctabs.diff and selector.diff) for review.

Regards,

Richard Quadling.
-- 
-----
Richard Quadling
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
"Standing on the shoulders of some very clever giants!"

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Prototype: Core" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/prototype-core?hl=en
-~----------~----~----~----~------~----~------~--~---

Attachment: selector.diff
Description: Binary data

Attachment: srctabs.diff
Description: Binary data

Reply via email to