On Oct 22, 6:41 am, Andy E <andyearns...@gmail.com> wrote:
[...]
> by the way, I noticed that your implementation will have problems when
> walking the DontEnum properties in Internet Explorer - it looks like
> you copied and pasted the line of code from the for...in loop to your
> for loop but forgot to change the variable that was passed in to the
> iterator function.
>
>             iterator.call(context || iterator, prop, object[prop]); //
> References to `prop` should be `DontEnumProperties[i]`
>
> Or store DontEnumProperties[i] in a variable for a small optimization.

Ah, yes. Thanks for catching that. That's lack of unit tests / code
review :)

[..]

--
kangax

-- 
You received this message because you are subscribed to the Google Groups 
"Prototype: Core" group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to 
prototype-core-unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/prototype-core?hl=en

Reply via email to