Hi,

For cloning, there's always Element#clone[1]. That clones the node
using the underlying DOM cloneNode function, and also handles anything
Prototype might have stored on the node.

> Apart from cloning an element I also needed to move an element from
> one div to another and I came up with this function...
> [snip]
> I don't like the switch part very much and tried to use the position
> variable directly but that somehow didn't work...anyone knows why?
> [snip]
>                 newParent.insert({position: element});

Because that creates a property called "position" on the options
object, exactly the way your earlier code

>                 newParent.insert({top: element});

...creates a property called "top" on the options object. The left-
hand side of a property initializer (and for that matter an
assignment) is used as the name of the property (or variable) to
create, not as a variable _containing_ the name of the property/
variable.

It is possible to do what you want, though:

    Element.addMethods({
        appendTo: function(element, newParent, position) {
            var options;
            element = $(element);
            newParent = $(newParent);
            options = {};
            options[position] = element;
            newParent.insert(options);
            return element;
    }});

...because the bracketed notation for property access uses strings for
property names, and lets you get the property name string from a
variable.

[1] http://api.prototypejs.org/dom/element/clone/

HTH,
--
T.J. Crowder
Independent Software Consultant
tj / crowder software / com
www.crowdersoftware.com


On Jun 20, 11:48 pm, David Behler <d.beh...@gmail.com> wrote:
> Hi guys,
>
> while looking for a way to clone an element, I stumbled upon this
> thread from 2007:
>
> http://groups.google.com/group/prototype-core/browse_thread/thread/9e...
>
> Any chance this is some when gonna end up in the core? I think this is
> function might be pretty useful sometimes.
>
> Apart from cloning an element I also needed to move an element from
> one div to another and I came up with this function which is basically
> a wrapper for the insert() function:
>
> Element.addMethods({
>         appendTo: function(element, newParent, position) {
>                 element = $(element);
>                 newParent = $(newParent);
>                 switch(position) {
>                         case 'top':
>                                 newParent.insert({top: element});
>                                 break;
>                         case 'bottom':
>                                 newParent.insert({bottom: element});
>                                 break;
>                         case 'before':
>                                 newParent.insert({before: element});
>                                 break;
>                         case 'after':
>                                 newParent.insert({after: element});
>                                 break;
>                 }
>                 return element;
>         }
>
> });
>
> I don't like the switch part very much and tried to use the position
> variable directly but that somehow didn't work...anyone knows why?
>
> Element.addMethods({
>         appendTo: function(element, newParent, position) {
>                 element = $(element);
>                 newParent = $(newParent);
>                 newParent.insert({position: element});
>                 return element;
>         }});
>
> $('test').appendTo('test2', 'top');
>
> Using this function Firebug shows this error: "insert is not a
> function".
>
> Anyway, maybe someone else finds this useful aswell :)
>
> David

-- 
You received this message because you are subscribed to the Google Groups 
"Prototype & script.aculo.us" group.
To post to this group, send email to prototype-scriptacul...@googlegroups.com.
To unsubscribe from this group, send email to 
prototype-scriptaculous+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/prototype-scriptaculous?hl=en.

Reply via email to