I've been thinking about re-implementing T-TEST, ONEWAY and EXAMINE, using category.c and thus retiring the rather ad hoc group.c and factor-stats.c files.
Several questions about category.c : 1. cat_value_find uses a linear search. Might is not be better to use a hash instead? 2. Do we really need cat-routines.h ? Can it not be merged into category.h ? 3. cat_value_update seems to do nothing for numeric variables. Why is this? A numeric variable can be used as a categorical variable just as easily as an alpha one. 4. If I'm reading the code right, cat_stored_values_destroy is leaky. It frees obs_vals, but doesn't tidy up obs_vals->vals . Also, shouldn't it set v->obs_vals to NULL after freeing? J' -- PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://pgp.mit.edu or any PGP keyserver for public key.
signature.asc
Description: Digital signature
_______________________________________________ pspp-dev mailing list [email protected] http://lists.gnu.org/mailman/listinfo/pspp-dev
