Follow-up Comment #2, patch #5731 (project pspp):
This is an improvement, but obviously there is more to be done.
Remove `stat-macros' module.
Why did you do that? It no longer builds, since several files include
stat-macros.h
While we're adjusting gl macros, can we get rid of strstr which no longer
exists in gnulib ?
+/* Spawn an interactive shell process. */
+static bool
shell (void)
{
+#if HAVE_FORK && HAVE_EXECL
int pid;
I think it's easier to read, if you put the function inside the #if /
#endifs
- if (fn_is_absolute (name))
+ if (name[0] == '/')
return xstrdup (name);
else
{
I prefer this how it was before. Especially, given the purpose of this
patch, and that w32 doesn't use '/' to seperate directories.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?5731>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
pspp-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/pspp-dev
