Follow-up Comment #1, patch #5812 (project pspp):
Looks OK to me.
1. For consistency with hash.c etc, you might want to consider renaming
sparse_array_create to sparse_array_create_pool, and if necessary make a new
function called sparse_array_create which wraps sparse_array_create_pool
passing NULL as the first argument.
2. Logically, the subject of parse_array_scan should be const. So far as I
can see, the reason you have not made it so, is that it modifies its cache_*
variables. If implemented in C++, of course, the solution would be to
declare these variables with the mutable qualifier. The compromise I make
when writing C is to simply cast away const on the mutable variables when I
need to assign them from a const method.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?5812>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
pspp-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/pspp-dev
