Update of patch #5874 (project pspp):

                  Status:   Ready For Test/Review => Works For Me           

    _______________________________________________________

Follow-up Comment #1:

Looks good.  A few nits:

It might be slightly clearer to write:
  strcpy (long_name, short_name);
  str_lowercase (long_name);

I wonder whether we should add a dictionary function to set both long and
short names at the same time.  It would avoid the need to duplicate the long
comment, for one.

In the future please consider using "cvs -q diff".  It makes patches slightly
easier to read by dropping all the "? unknown/file/name" lines.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?5874>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
pspp-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/pspp-dev

Reply via email to