Follow-up Comment #3, patch #5968 (project pspp):
There's still one outstanding instance of var_get_type (v[i]) == VAR_STRING,
which might be better written as var_is_alpha(v[i]).
The assignment tmp = 1.0; could now be removed, and tmp initialised to 1.0 as
declaration.
Looking at this function now, I'm not sure if it'll behave itself if n_vars
is zero. Perhaps it never will be, in which case an assertion to that effect
wouldn't hurt.
Maybe you want to consider doing these things. I'm happy for it to be
checked in anyway.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?5968>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
pspp-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/pspp-dev
