John Darrington <[EMAIL PROTECTED]> writes: > I'm concerned about get_termcap_viewport currently in > src/data/settings.c > > 1. It means that src/data/libdata.a contains part of a user interface > implementation (and in this case makes it depend on libncurses > which is silly). > > 2. Using the terminal's width and length is obviously appropriate for > the terminal interface, but inappropriate for the GUI where the > dimensions of the output window are what matter. > > 3. In the case of the terminal interface, shouldn't there be something > connecting to SIGWINCH, so that width and length will change > accordingly when an xterm is resized? > > I suggest that settings_init takes a pointer to a function, which > fetches the viewport dimensions. That way, it can work for both graphic > and terminal user interfaces.
I think you are right. Do you want to take a stab at this, or shall I? -- Ben Pfaff [EMAIL PROTECTED] _______________________________________________ pspp-dev mailing list [email protected] http://lists.gnu.org/mailman/listinfo/pspp-dev
