Follow-up Comment #1, patch #6210 (project pspp):
I think that the new version of get_termcap_viewport calls
set_fallback_viewport unconditionally, not just when tgetnum fails to return
good values.
I do not think it is a good idea to do so much work from a signal handler.
It would be better if the signal handler could just set a flag that
higher-level code could notice and act upon. I think that this would require
using a select(2) loop and rl_callback_read_char in readln_read in place of
the current simple call to readline or ds_read_line. I don't know whether you
are familiar with the care and feeding of such loops: if not, I'd be happy to
code one for you.
The long_view variable appears to be effectively dead: although
force_long_view can set it to true, there is no call to force_long_view
anywhere in the source tree. I don't recall what it was originally for.
As long as popup_message is changing anyhow, I think that "Syntax Error" is a
better name than "Script Error". I am trying to move away from the term
"script", at least in user documentation and user-visible messages, because it
is not a term used by that other software.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?6210>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
pspp-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/pspp-dev
