Follow-up Comment #1, patch #6635 (project pspp):
Good work. It takes a lot of motivation, at least on my own part, to track
down implementations of code and then ask their authors to relicense it, and
so I admire that you have done it so successfully.
A few comments:
* "asymptotic" is misspelled in the documentation (extra "s").
* Regarding the signal handler, another way that you might consider, if it is
appropriate, is simply to set a variable from the signal handler, then
periodically that variable's value. The code in src/libpspp/model-checker.c
does this, for example.
* Along the same lines, you might consider handling SIGINT also, so that the
user can interrupt the processing with ^C and no harm done. (Probably, we
should make this apply to all PSPP commands at some point, but it seems fine
to me to special-case it for now.)
* I don't see any reason to use SA_NODEFER, unless it is to ensure that
jumping out of the signal handler does not leave the signal blocked forever.
The conventional (and slightly safer) way to do that, I think, would be to use
sigsetjmp(). with "1" as the second argument, and siglonjmp(), in place of
plain setjmp() and longjmp()
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?6635>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
pspp-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/pspp-dev
