Follow-up Comment #1, patch #6719 (project pspp):
I think its an improvement over the existing version. I'm beginning to
understand what an "interaction" is now.
Several comments:
0. The copyright notices are 2 years out of date!
1. If I'm understanding how it's supposed to work, then "struct variable
**members" should be "const struct variable **members" since none of the
members will be modified by the interaction. interaction_variable_create then
should take a const first argument.
2. Arg 2 of interaction_value_create should also be const
3. Likewise, arg 1 of interaction_variable_get_n_vars
4. It looks to me as if interaction_value_create is going to cause a buffer
overflow. result->strings has a width of MAX_SHORT_STRING but you are writing
to it MAX_SHORT_STRING * n_vars bytes + 1 bytes.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?6719>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
pspp-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/pspp-dev
