Update of patch #6785 (project pspp):
Status: In Progress => Works For Me
_______________________________________________________
Follow-up Comment #1:
I'm OK with this conceptually. I have a few comments about details:
* I don't like the extra two blank lines added to format.h.
* COUNT_FMT is defined but never used.
* Please don't comment code as in do_summary_box() in npar-summary.c, and as
in npar-summary.h. Just delete it. We can always find it in the Git history
if we need it.
* Code like this appears repeatedly:
+ const struct variable *wv = dict_get_weight (dict);
+ const struct fmt_spec *wfmt = wv ? var_get_print_format (wv) : & F_8_0;
Perhaps a helper function is warranted?
* table.c was modified to use __FUNCTION__, but that is GCC-specific. Gnulib
has a module named 'func' can can help out, but you have to use __func__
instead (and __func__ is an object, not a macro).
* tab_double() could avoid copying 'fmt' by just writing "if (fmt == NULL)
fmt = settings_get_format();" instead of always copying into a local
variable.
Thanks for taking care of this!
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?6785>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
pspp-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/pspp-dev
