Thanks. I filed bug #28883. John Darrington <[email protected]> writes:
> One thing is for sure: that code could use some more comments. > > The analyser is correct. A null pointer dereference could potentially > occur if the PSQL library server started behaving oddly. However, this > feature has some quite comprehensive tests, and there's been no problem > so far. > > I suggest that we raise a bug about this, so that I can fix it when I > get time. > > J' > > On Thu, Feb 12, 2010 at 10:28:35PM -0800, Ben Pfaff wrote: > I ran clang-analyzer (http://clang-analyzer.llvm.org) on the PSPP > source tree and here is the report: > http://benpfaff.org:8181/ > > Some of the reports are correct. Others are false positives. I > am not sure about the ones for psql-reader.c (which are all quite > similar): > http://benpfaff.org:8181/report-5PvYYA.html#EndPath > http://benpfaff.org:8181/report-sP82Pb.html#EndPath > http://benpfaff.org:8181/report-nSLyIM.html#EndPath > http://benpfaff.org:8181/report-h6avCn.html#EndPath > > They look plausible but I don't understand the code well enough > to say for sure. Can you take a look at those (and any others > that you would like to)? > -- > "The sound of peacocks being shredded can't possibly be > any worse than the sound of peacocks not being shredded." > Tanuki the Raccoon-dog in the Monastery -- "Then, I came to my senses, and slunk away, hoping no one overheard my thinking." --Steve McAndrewSmith in the Monastery _______________________________________________ pspp-dev mailing list [email protected] http://lists.gnu.org/mailman/listinfo/pspp-dev
