John Darrington <[email protected]> writes: > On Mon, Sep 20, 2010 at 10:50:20PM -0700, Ben Pfaff wrote: > When I was looking at other code tonight, I noticed some problems > with the recode_string() function. This series fixes them up. > > I don't see any problems with any of these patches, although I haven't > actually tried them.
Thank you, I pushed them. > I suspect that the testsuite does not exercise this function all > that well, but it does pass with these changes. > > So far as I'm aware, there are no tests whatsoever for this function. > We should add some and do some coverage analysis too. OK, I've written a few simple tests. I'll email them out in a moment. I didn't do coverage analysis. I suspect that my tests don't exercise the logic to enlarge the buffer. -- Ben Pfaff http://benpfaff.org _______________________________________________ pspp-dev mailing list [email protected] http://lists.gnu.org/mailman/listinfo/pspp-dev
