Thanks for having a look. I pushed these to "master". John Darrington <[email protected]> writes:
> These all look fine to me. > On Sat, Dec 11, 2010 at 10:19:54PM -0800, Ben Pfaff wrote: > This is a series of fixes for warnings, followed by various > minor improvements scattered around the tree. I'd appreciate > any comments. > > Thanks, > > Ben. > > Ben Pfaff (18): > friedman: Fix GCC warning about uninitialized fr.w. > mann-whitney: Suppress GCC warning about unused parameter. > ONEWAY: Fix warning for passing "const" pointer as non-const > parameter. > covariance: Fix const-ness of covariance_calculate[_unnormalized] > retval. > categoricals: Make parameter to categoricals_done() const. > expressions: Make extract_min_valid() parameter const. > INPUT PROGRAM: Remove unused enumeration. > DEBUG XFORM FAIL: Issue an error message as part of transformation. > q2c: Prefer lex_match_id() over lex_match_hyphenated_word() in > emitted code. > NPAR TESTS: Prefer lex_match_id() over lex_match_hyphenated_word() > identifier: New function token_type_to_string(). > DO REPEAT: Make this command usable anywhere. > float-format: Don't translate test strings. > ECHO: Use text_item, as intended. > i18n: Remove unnecessary #ifs. > AGGREGATE: Align arg_func_tab[] in columns. > GET DATA: Fix punctuation in error message. > value-parser: Remove redundant call to lex_force_string() in > parse_value(). > > src/data/identifier.c | 16 +++++++ > src/data/identifier.h | 79 > ++++++++++++++++++++----------------- > src/language/command.def | 4 +- > src/language/data-io/get-data.c | 2 +- > src/language/data-io/inpt-pgm.c | 9 ---- > src/language/expressions/parse.c | 2 +- > src/language/lexer/q2c.c | 4 +- > src/language/lexer/value-parser.c | 7 +--- > src/language/stats/aggregate.c | 41 ++++++++++--------- > src/language/stats/correlations.c | 3 +- > src/language/stats/factor.c | 4 +- > src/language/stats/friedman.c | 2 + > src/language/stats/glm.c | 2 + > src/language/stats/mann-whitney.c | 2 +- > src/language/stats/npar.c | 34 ++++++++-------- > src/language/stats/oneway.c | 14 ++++--- > src/language/stats/regression.q | 2 +- > src/language/tests/float-format.c | 7 +-- > src/language/utilities/echo.c | 22 ++++------ > src/language/xforms/fail.c | 15 +++---- > src/libpspp/i18n.c | 4 -- > src/math/categoricals.c | 5 +- > src/math/categoricals.h | 4 +- > src/math/covariance.c | 34 ++++++++-------- > src/math/covariance.h | 6 +- > tests/language/stats/rank.at | 2 + > 26 files changed, 170 insertions(+), 156 deletions(-) > > > _______________________________________________ > pspp-dev mailing list > [email protected] > http://lists.gnu.org/mailman/listinfo/pspp-dev -- Ben Pfaff http://benpfaff.org _______________________________________________ pspp-dev mailing list [email protected] http://lists.gnu.org/mailman/listinfo/pspp-dev
