On Wed, Apr 25, 2012 at 09:35:52PM -0700, Ben Pfaff wrote:
John Darrington <j...@darrington.wattle.id.au> writes:
> The attatched patch makes a solution to bug #31566 possible.
>
> It replaces the const char* with a struct string *
I don't like the idea of doing this extra allocation, copying,
and deallocation if we can avoid it.
I'm not particularly happy with it either.
One way, for example, would be to add a new var_* function that
returns the variable name and label together, keeping the string
cached as part of the struct variable.
I can see that would work. However, I don't like the idea of having the
data and its presentation in the same structure. I think we ought to
start making an effort to keep them apart.
Have you any other suggestions?
J'
--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.
signature.asc
Description: Digital signature
_______________________________________________ pspp-dev mailing list pspp-dev@gnu.org https://lists.gnu.org/mailman/listinfo/pspp-dev
