This looks fine to me. However, I feel obliged to ask the question why are we actually calling g_thread_init. The docs say this is necessary iff we are calling GLib from more than one thread. So far as I'm aware, we're not doing that, are we?
J'
On Fri, May 04, 2012 at 09:33:32PM -0700, Ben Pfaff wrote:
Seems to be required on OpenSUSE.
Reported by Mindaugas.
Bug #36396.
---
configure.ac | 3 +++
src/ui/gui/automake.mk | 1 +
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/configure.ac b/configure.ac
index 7d33ca2..2f3a8da 100644
--- a/configure.ac
+++ b/configure.ac
@@ -73,6 +73,9 @@ AC_ARG_WITH([gui],
AM_CONDITIONAL([HAVE_GUI],
[test "$with_cairo" != no && test "$with_gui" != "no"])
if test "$with_cairo" != no && test "$with_gui" != "no"; then
+ PKG_CHECK_MODULES([GTHREAD], [gthread-2.0], [],
+ [PSPP_REQUIRED_PREREQ([gthread 2.0 (or use --without-gui)])])
+
PKG_CHECK_MODULES([GTK], [gtk+-2.0 >= 2.16], [],
[PSPP_REQUIRED_PREREQ([gtk+ 2.0 version 2.16 or later (or use
--without-gui)])])
diff --git a/src/ui/gui/automake.mk b/src/ui/gui/automake.mk
index 96209a0..a7cb1de 100644
--- a/src/ui/gui/automake.mk
+++ b/src/ui/gui/automake.mk
@@ -74,6 +74,7 @@ src_ui_gui_psppire_LDADD = \
src/libpspp.la \
src/libpspp-core.la \
$(GTK_LIBS) \
+ $(GTHREAD_LIBS) \
$(GTKSOURCEVIEW_LIBS) \
$(CAIRO_LIBS) \
$(LIBINTL) \
--
1.7.2.5
_______________________________________________
pspp-dev mailing list
pspp-dev@gnu.org
https://lists.gnu.org/mailman/listinfo/pspp-dev
--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.
signature.asc
Description: Digital signature
_______________________________________________ pspp-dev mailing list pspp-dev@gnu.org https://lists.gnu.org/mailman/listinfo/pspp-dev
