Ben Pfaff <b...@cs.stanford.edu> writes: > John Darrington <j...@darrington.wattle.id.au> writes: > >> On Sat, Jul 07, 2012 at 11:49:15PM -0700, Ben Pfaff wrote: >> If the PsppireDict is destroyed before its dictionary, then >> it is important to avoid getting callbacks into the freed >> PsppireDict. >> >> +static void >> +psppire_dict_dispose (GObject *object) >> +{ >> + PsppireDict *d = PSPPIRE_DICT (object); >> + >> + dict_set_callbacks (d->dict, NULL, NULL); >> + >> + G_OBJECT_CLASS (parent_class)->dispose (object); >> +} >> >> Normally, we need to have some mechanism to render _dispose >> impotent if it gets called more than once for the same instance. >> I don't know if dict_set_callbacks could do anything bad if it >> gets called multiple times. If it could, then we need to add a >> dispose_has_run flag here. > > It won't do anything bad, so I'm going to leave that alone.
I pushed the first 3 commits to "master" and then merged "master" into "psppsheet". _______________________________________________ pspp-dev mailing list pspp-dev@gnu.org https://lists.gnu.org/mailman/listinfo/pspp-dev