John Darrington <j...@darrington.wattle.id.au> writes: > On Sun, Jul 08, 2012 at 11:45:48PM -0700, Ben Pfaff wrote: > g_object_get() returns a string copy, so the caller has to free it. > > Found by valgrind. > --- > Review appreciated. > > It seems rather pointless to make a deep copy of this string, only to > immediately free it. > So if g_object_get insists on copying, then I suggest we just use > gtk_widget_get_name which > does not.
That's much better. I changed the commit to do that and pushed it. _______________________________________________ pspp-dev mailing list pspp-dev@gnu.org https://lists.gnu.org/mailman/listinfo/pspp-dev
