On Tue, Jul 10, 2012 at 07:35:10AM -0700, Ben Pfaff wrote:
> There doesn't seem to be anything initialising de->data_window
> to NULL so there is still a potential leak here.
A leak, or passing a bad pointer to g_object_unref()?
> However I don't see a need to keep a reference here at
> all. ->data_window is used only by the do_sort function, and
> that cannot be called unles the window is realized.
That sounds like a better approach, then, as long as we add a
comment somewhere that says why we don't need a reference. Do
you want to make that change?Done -- PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://keys.gnupg.net or any PGP keyserver for public key.
signature.asc
Description: Digital signature
_______________________________________________ pspp-dev mailing list pspp-dev@gnu.org https://lists.gnu.org/mailman/listinfo/pspp-dev
