On Fri, Jul 13, 2012 at 07:35:08AM -0700, Ben Pfaff wrote:
Thanks. I pushed them.
Do you know why var-type-dialog has two toggle handlers,
on_toggle_1 and on_toggle_2? It seems to me that they could be
combined.
There's probably no good reason. Occasionally it makes sense from a
code maintenance point of view, at the expense of slightly slower
execution. However, this file was one of the very first Gtk code
that I wrote. So if it makes sense to combine them, then please
feel free.Eventually, this entire dialog ought to be rewritten as an object driving from GtkWindow/GtkDialog/PsppireDialog. -- PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://keys.gnupg.net or any PGP keyserver for public key.
signature.asc
Description: Digital signature
_______________________________________________ pspp-dev mailing list pspp-dev@gnu.org https://lists.gnu.org/mailman/listinfo/pspp-dev
