Thanks for looking them over. I pushed these to master. I think the next step is probably to make this dialog a GObject.
John Darrington <j...@darrington.wattle.id.au> writes: > I haven't tested this, but all of the changes look like improvements to me. > > J' > > On Sun, Jul 29, 2012 at 11:58:43PM -0700, Ben Pfaff wrote: > These changes make the code smaller and eliminate a good deal of > redundancy. They also make it easier to use by replacing the > GtkEntry widgets by GtkSpinButtons, and fix a Glib-CRITICAL that > occurred when the user chose invalid width or decimal places for > a custom currency format. > > Ben Pfaff (4): > var-type-dialog: Properly adjust formats when switching buttons. > var-type-dialog: Reduce redundancy. > var-type-dialog: Reduce redundancy further. > var-type-dialog: Change entries to spin buttons, add validation. > > src/ui/gui/var-type-dialog.c | 561 > +++++++++++++++++------------------------ > src/ui/gui/var-type-dialog.h | 4 +- > src/ui/gui/var-type-dialog.ui | 24 ++- > 3 files changed, 261 insertions(+), 328 deletions(-) > > -- > 1.7.2.5 > > > _______________________________________________ > pspp-dev mailing list > pspp-dev@gnu.org > https://lists.gnu.org/mailman/listinfo/pspp-dev _______________________________________________ pspp-dev mailing list pspp-dev@gnu.org https://lists.gnu.org/mailman/listinfo/pspp-dev
