Ben Pfaff <b...@cs.stanford.edu> writes: > Ben Pfaff <b...@cs.stanford.edu> writes: > >> I see some new warnings on master. This one looks serious: >> >> src/data/ods-reader.c: In function ‘ods_open_reader’: >> src/data/ods-reader.c:596: error: passing argument 1 of >> ‘ods_file_casereader_destroy’ from incompatible pointer type >> src/data/ods-reader.c:120: note: expected ‘struct casereader *’ but argument >> is of type ‘struct zip_reader *’ > > Looking more closely at this one, I guess we can just pass NULL > for that argument, since the function doesn't use it.
I checked in that fix. > I don't see anything that destroys struct ods_reader's dict in > the successful case, so perhaps the dict_destroy() should be > moved into ods_file_casereader_destroy() so it gets executed in > both cases? I didn't do anything about this. John, do you want to see whether this is a real leak? Thanks, Ben. _______________________________________________ pspp-dev mailing list pspp-dev@gnu.org https://lists.gnu.org/mailman/listinfo/pspp-dev
