On Sun, Mar 10, 2013 at 09:03:09AM -0700, Ben Pfaff wrote: > On Sat, Mar 09, 2013 at 07:44:10PM +0100, John Darrington wrote: > > I'm posting this proposed change for review purposes. It enables import of > > spreadsheet files using the gui. > > This sounds like a useful feature. I'm going to look over the changes > today.
I see some "printf"s sprinkled into the code. I guess these are stray debugging code that has not yet been removed. It looks like most of the patch is moving code around. I see a some new code, but it is hard to spot in the motion. Is there any particular code that you'd like to draw my attention to? If not, then this seems like a reasonable set of changes to me. I didn't compile or test this. _______________________________________________ pspp-dev mailing list pspp-dev@gnu.org https://lists.gnu.org/mailman/listinfo/pspp-dev
