That is reasonable. I pushed such a change. On Sat, Sep 4, 2021 at 12:29 AM John Darrington < j...@darrington.wattle.id.au> wrote:
> On Thu, Sep 02, 2021 at 09:46:04PM -0400, Ben Pfaff wrote: > > - Log > ----------------------------------------------------------------- > commit 051724c1769c04a715f00f22f75c4a810f5bff11 > Author: Ben Pfaff <b...@cs.stanford.edu> > Date: Thu Sep 2 18:45:39 2021 -0700 > > sys-file-encoding: Put the buffer-read-only declaration at the > very top. > > This accidentally got pushed down when license notices were added > to a > bunch of files en masse. It only works if it's at the top. > > src/data/sys-file-encoding.c | 10 +++++----- > > > If this file is generated, then why do we have it in GIT at all? Let's > generate it as part of the build process (or if that is impractical as part > of the pre-configure process) > > Otherwise, how can we be sure that the generation process acutally works? > > When I run perl src/data/sys-file-encodings.c I get the message: > > To regenerate the encoding data, get the latest ICU encoding data from: > > http://source.icu-project.org/repos/icu/icu/trunk/source/data/mappings/convrtrs.txt > > But that URL returns 404 > > J' > > >
