I'm glad you fixed it. I'm not so happy with the details of the fix because
it requires developers to realize that they need the fix and include a
special header for it. That kind of thing leads to repeated problems over
time.
I think that the attached commit would have fixed the problem without the
need for developers to know to include a header.
On Sun, Jul 10, 2022 at 2:54 PM Friedrich Beckmann <
friedrich.beckm...@gmx.de> wrote:
> The fix did not work on debian. I pushed a different fix.
>
> > Am 09.07.2022 um 17:39 schrieb Ben Pfaff <b...@cs.stanford.edu>:
> >
> > I think I fixed this. I started a build.
> >
>
>
From 38f0524abbcb4977d8f51a94866d578c12a769d3 Mon Sep 17 00:00:00 2001
From: Ben Pfaff <b...@cs.stanford.edu>
Date: Mon, 11 Jul 2022 08:54:05 -0700
Subject: [PATCH] gui: Make sure header wrapper gets used for widgets, not just
main GUI.
This should really fix the problem with g_memdup2().
Reported by Jeremy Lavergne.
Bug #62747.
---
src/ui/gui/automake.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/ui/gui/automake.mk b/src/ui/gui/automake.mk
index d6b686db40..69ff3f9ed7 100644
--- a/src/ui/gui/automake.mk
+++ b/src/ui/gui/automake.mk
@@ -372,6 +372,8 @@ src_ui_gui_libwidgets_essential_la_CFLAGS = \
$(SPREAD_SHEET_WIDGET_CFLAGS) \
$(AM_CFLAGS)
+src_ui_gui_libwidgets_essential_la_CPPFLAGS = $(AM_CPPFLAGS) -Isrc/ui/gui/include
+
# The unused-parameter warning is not by default disabled
# in AM_CFLAGS because the core pspp code has this enabled.
# This is only disabled in the gui code where we have many
--
2.36.1
