Hi!
>>>>> Niels Möller writes:
NM> I think it would make sense to have a configure time option
NM> --with-sshd1, to make it possible to (i) disable the callback
NM> code completely, and (ii) specify a default path for the sshd1
NM> program.
I'm not sure I understand your rationale. Could you describe any
reasons why you would want to compile out the fallback code? With my
patch, ``disabling it completely'' is done when --ssh1-fallback is not
specified.
I don't understand the real difference between:
if (connection->fallback)
{
...
}
and
#ifdef SSH1_FALLBACK
if (connection->fallback)
{
...
}
#endif
except that the second form forces you to recompile the package if you
accidentally forgot a configure switch.
Could you explain what you see as the drawbacks of the first form?
NM> I agree that it seems unnecessary to try to figure out
NM> automatically whether or not a suitable sshd1 program is
NM> available. In any case, a runtime option is definitely nedded.
If we have both runtime and compile-time options, then we create four
separate code paths. Then, also, other people's programs might have
to do configure tests to see if --ssh1-fallback is supported by a
given lshd. I'd rather go for consistency across all platforms and
implementations, where possible.
NM> Thanks. Seems there will be a lot of things I have to integrate
NM> next week.
No rest for the wicked. ;)
NM> Bazsi is already working on pty support. Please coordinate with
NM> him before you start to work on the pty stuff.
Okay, I'll do that.
Thanks,
--
Gordon Matzigkeit <[EMAIL PROTECTED]> //\ I'm a FIG (http://www.fig.org/)
Lovers of freedom, unite! \// I use GNU (http://www.gnu.org/)
[Unfortunately, www.fig.org is broken. Please stay tuned for details.]
