Hi,

I am looking into implementing client requests when the connection protocol
is up and running. (e.g. request opening a channel, a pty and a shell)

As I understand I should derive different classes from 
channel_request_command, and use the format_request method to generate a
request to be sent. This is where I found some inconsistency:

Here's the declaration of channel_request_command:

/* GABA:
   (class
     (name channel_request_command)
     (super command)
     (vars
       ;; This method should return a formatted request. The
       ;; want_reply field in the request should be non_zero iff *c is
       ;; non-NULL on return.
       (format_request method "struct lsh_string *"
                       "struct ssh_channel *channel"
                       "struct command_continuation **c")))
*/

and here's the invocation of format_request (from channel_commands.c):

  struct lsh_string *request
    = FORMAT_CHANNEL_REQUEST(self, channel, !!c);

The problem is with the "command_continuation **c" parameter, I think the
declaration should be "int want_reply" instead. I am going with this
want_reply approach, and please tell me if I was wrong.

-- 
Bazsi
PGP key: http://www.balabit.hu/pgpkey.txt, or finger [EMAIL PROTECTED]

Reply via email to