Robert Schwebel wrote:
> Hi Gary,
> 
> [redirecting the discussion to ptxdist]
> 
> On Mon, Dec 15, 2008 at 07:49:39AM -0700, Gary Thomas wrote:
>> [email protected] wrote:
>>> Author: rsc
>>> Date: 2008-12-04 15:43:28 +0100 (Thu, 04 Dec 2008)
>>> New Revision: 9187
>>>
>>> Added:
>>>    
>>> trunks/ptxdist-trunk/patches/CanFestival-3-20081204-1/generic/fix-destdir.diff
>>>   
>> Isn't this patch a bit heavy-handed?  Why not just change the install
>> step in the canfestival.make to be
>>   make install PREFIX=$(DESTDIR)
> 
> Nope, seems right. The usual semantics is
> 
> - PREFIX specifies the location in the runtime system ("where is the
>   code to be run in the target box")
> 
> - DESTDIR specifies the temporary location ("where is the root of the
>   target system located temporarily on the development box")

Understood.  What I really meant was
  make install PREFIX=$(DESTDIR)/usr
rather than patching all of the incoming Makefile(s)?  All that patch
does is replace $(PREFIX) with $(DESTDIR)/$(PREFIX) and this mechanism
is already available in the Makefile(s) by overriding $(PREFIX) as above.

As is, the 'fix-destdir' patch is not something that could ever be accepted
upstream.


-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

--
ptxdist mailing list
[email protected]

Reply via email to