Marc Kleine-Budde wrote:
> Remy Bohmer wrote:
>> Ptxdist assumes that dtc is only required on powerpc targets,
>> but is also used by newer U-boot mkimage tools that demand at least
>> version v1.2.0
> 
> commited, tnx
>> Signed-off-by: Remy Bohmer <[email protected]>
>> ---
>>  platforms/dtc.in    |   17 +++++++++++++++++
>>  rules/host-dtc.make |    2 +-
>>  2 files changed, 18 insertions(+), 1 deletions(-)
>>
>> diff --git a/platforms/dtc.in b/platforms/dtc.in
>> index fd94b02..2b99f33 100644
>> --- a/platforms/dtc.in
>> +++ b/platforms/dtc.in
>> @@ -1,5 +1,22 @@
>>  config HOST_DTC
> 
> please make this a menuconfig
> 
>>      bool
>> +    prompt "Build device tree compiler    "
>> +    help
>> +      Select this if the HOST_DTC tool is required without
>> +      building a device tree. (It is also used for building
>> +      U-boot FIT images)
>> +
>> +if HOST_DTC
>> +
>> +config HOST_DTC_VERSION
>> +        string
>> +        prompt "Device tree compiler version    "
>> +    default "v1.2.0"
>> +        help
>> +          Specify the DTC version number to be used
>> +
>> +endif
>> +
>>  
>>  menuconfig DTC
>>      bool
>> diff --git a/rules/host-dtc.make b/rules/host-dtc.make
>> index c4a5b61..7adab9a 100644
>> --- a/rules/host-dtc.make
>> +++ b/rules/host-dtc.make
>> @@ -17,7 +17,7 @@ HOST_PACKAGES-$(PTXCONF_HOST_DTC) += host-dtc
>>  #
>>  # Paths and names
>>  #
>> -HOST_DTC_VERSION    := v1.2.0
>> +HOST_DTC_VERSION    := $(call remove_quotes,$(PTXCONF_HOST_DTC_VERSION))

specifying a version beginning with "v" seems unintuitive for me, thus I
moved the "v" here:

>>  HOST_DTC            := dtc-$(HOST_DTC_VERSION)
                               ^
>>  HOST_DTC_SUFFIX             := tgz
>>  HOST_DTC_URL                := 
>> http://www.jdl.com/software/$(HOST_DTC).$(HOST_DTC_SUFFIX)

cheers, Marc

-- 
Pengutronix e.K.                         | Marc Kleine-Budde           |
Linux Solutions for Science and Industry | Phone: +49-231-2826-924     |
Vertretung West/Dortmund                 | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686         | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature

--
ptxdist mailing list
[email protected]

Reply via email to