Carsten Schlote wrote:
>>>         ;;
>>>     VERSION)
>>> -       replace_to="${replace_to}${PTXCONF_PROJECT_BUILD}"
>>> +       replace_to="`echo ${replace_to} | sed -e 's/-
>> /./'`${PTXCONF_PROJECT_BUILD}"
>>
>> please use bash magic for this: "${replace_to//-/.}"
>> (this actually is: "s/-/./g", what about "_" in the version string?
> 
> Not yet covered, because this wasn't an issue yet. But of course '_'
> will mess
> up the ipkg-push script as well.

Hmmm...after rereading the text, I realized that you said "ipkg-push"
has problems. The script was written by pengutronix and probably never
in heavy use.

If ipkg is fine with the versions, IMHO we should fix the script. Or
better said: ipkg should limit us here, not the ipkg-push script.

> I will add some handling for it as well.
> 
> Is the conversion from '-' to '.' ok? Or should it be some other
> character?

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature

--
ptxdist mailing list
ptxdist@pengutronix.de

Reply via email to