On Fri, Jan 29, 2010 at 11:22:05AM +0100, [email protected] wrote: [...] > + config SPEEX_FFT_GPL_FFTW3 > + bool > + depends on BROKEN > + prompt "gpl-fftw3 [BROKEN]" > + > + config SPEEX_FFT_PROPRIETARY_INTL_MKL > + bool > + depends on BROKEN > + prompt "proprietary-intel-mkl [BROKEN]"
I don't think "gpl" and "proprietary" should be in the variable names. > +SPEEX_PATH := PATH=$(CROSS_PATH) > +SPEEX_CONF_ENV := $(CROSS_ENV) These can be removed. The default stages use the default values if the variables are not set. So only set them if the value is not the default, or if they are used later in the makefile > +# > ---------------------------------------------------------------------------- > +# Clean > +# > ---------------------------------------------------------------------------- > + > +#$(STATEDIR)/speex.clean: > +# @$(call targetinfo) > +# @$(call clean_pkg, SPEEX) Please remove this. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list [email protected]
