Michael Grzeschik wrote:
>       * This patch repairs a bug in the host function of the
>         libptxdisttest.sh which did not correctly handle the
>         return value of the evaluated commandline.

the patches look good now, although the commit messages are formated in
a unusual way, no stars, please :)

I'll fix that,
cheers, Marc
> 
> Signed-off-by: Michael Grzeschik <[email protected]>
> ---
>  tests/libptxdisttest.sh |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/libptxdisttest.sh b/tests/libptxdisttest.sh
> index 5e79b63..00a9244 100644
> --- a/tests/libptxdisttest.sh
> +++ b/tests/libptxdisttest.sh
> @@ -121,7 +121,7 @@ test_end() {
>  }
> 
>  checking() {
> -     printf "%-71s" "checking $1" >&2
> +     printf "%-71s\n" "checking $1" >&2
>       reportwrite checking "$1"
>  }
> 
> @@ -190,10 +190,12 @@ remote() {
>  }
> 
>  host() {
> +     local stdout
> +
>       echo "${1}" >> "$LOGFILE"
>       reportwrite host "${1}"
> -     local stdout=$(eval ${1}) 2>> "$LOGFILE"
> -     local retval=$?
> +     stdout=$(eval ${1}; exit ${?}) 2>>"$LOGFILE"
> +     local retval=${?}
>       reportwrite stdout "${stdout}"
>       reportwrite exitstatus ${retval}
>       echo "$stdout"


-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature

-- 
ptxdist mailing list
[email protected]

Reply via email to