On Mon, May 31, 2010 at 05:26:55PM +0200, Tim Sander wrote:
> Hi Michael
>
> Thanks for your review.
> > > @@ -111,6 +112,7 @@ $(STATEDIR)/dbus.targetinstall:
> > > /usr/lib/libdbus-1.so.3.4.0)
> > > @$(call install_link, dbus, libdbus-1.so.3.4.0,
> > > /usr/lib/libdbus-1.so.3) @$(call install_link, dbus, libdbus-1.so.3.4.0,
> > > /usr/lib/libdbus-1.so) + @$(call install_dir, dbus, 0, 0, 0755, -,
> > > /var/lib/dbus)
> >
> > This has nothing to do with upstart, right? If this directory needs to
> > there for dbus, please provide a separate patch with an appropriate
> > description.
> Well kind of. The initmethod.bbinit creates this method if it's not there. The
> upstart init doesn't create that directory. So this is there to make dbus
> happy when started with dbus.conf in /etc/init. It does no harm to bbinit.
I don't see the creation of /var/lib/dbus, only /var/run/dbus. There is
however a patch that moves machine-id from /var/lib/dbus to /var/run/dbus.
The problem is that /var/lib of often not writeable on read-only file
systems.
And you have a "mkdir -p /var/run/dbus" in the dbus.conf "pre-start script"
section.
Are you sure you need the install_copy?
> Will breakout the libnih patches later. Does anybody know if there is a nice
> way to tell git to reformat the patches?
$ git reset HEAD~1
This will undo the last commit but keeps the changes in the working copy.
while "there are uncomitted changes" do
git add ...
git commit -s
done
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
[email protected]
