On Mon, May 31, 2010 at 10:26:46PM +0200, Michael Olbrich wrote:
> > +DCONF_LICENSE      := unknown
> 
> DCONF_LICENSE := LGPLv2.1

added

> > +   @$(call install_copy, dconf, 0, 0, 0644, -, 
> > /usr/lib/gio/modules/libdconfsettings.so)
> > +   @$(call install_lib,  dconf, 0, 0, 0644, libdconf)
> > +   @$(call install_copy, dconf, 0, 0, 0644, -, /usr/libexec/dconf-service)
> > +   @$(call install_copy, dconf, 0, 0, 0644, -, /usr/bin/dconf)
> 
> something in /usr/bin and not executable? This looks wrong.
> Same for /usr/libexec/
> 
> And please add some line breaks.

changed

Thanks,
rsc
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
[email protected]

Reply via email to