On Tue, Jun 01, 2010 at 12:50:11AM +0200, Tim Sander wrote:
> +config LIBNIH
> +       bool
> +       prompt "libnih"
> +       select DBUS
> +       select HOST_LIBNIH
> +       help
> +         libnih is a small library for C application development containing 
> functions that, despite its name, are not implemented elsewhere in the 
> standard library set.

Can you add line breaks to be shorter than 80 chars minus Kconfig
borders, please?

> +# Copyright (C) 2010 by Tim Sander

Usually this should also contain a mail address.

> +# See CREDITS for details about who has contributed to this project.

Please add yourself to the CREDITS file.

> +LIBNIH_VERSION := 1.0.2
> +LIBNIH         := libnih-$(LIBNIH_VERSION)
> +LIBNIH_SUFFIX := tar.gz
> +LIBNIH_URL := 
> http://launchpad.net/libnih/1.0/$(LIBNIH_VERSION)/+download/$(LIBNIH).$(LIBNIH_SUFFIX)
> +LIBNIH_DIR             := $(BUILDDIR)/$(LIBNIH)
> +LIBNIH_SOURCE  := $(SRCDIR)/$(LIBNIH).$(LIBNIH_SUFFIX)

Please specify LIBNIH_LICENSE.

> +       @$(call install_fixup, libnih, AUTHOR, "Tim Sander")

Mailaddress, please.

> +# 
> ----------------------------------------------------------------------------
> +# Clean
> +# 
> ----------------------------------------------------------------------------
> +
> +libnih_clean:
> +       rm -rf $(STATEDIR)/libnih.*
> +       rm -rf $(PKGDIR)/libnih_*
> +       rm -rf $(LIBNIH_DIR)

It should be possible to remove the clean stage completely.

rsc
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
[email protected]

Reply via email to