On Thu, Jun 03, 2010 at 08:41:04PM +0200, Remy Bohmer wrote:
> >> libusb-1.0.6 has patches, are they obsolete?
> >
> > Hmm, strange, I must have missed the trac thread. I don't really
> > remember a test case, will search...
>
> There is only 1 single patch there that adds 2 libraries during
> linking, but it does not tell why these libraries were needed.

We once had a test case where it was necessary to add the libs, but I
don't remember the details. Unfortunately, it is not documented
properly.

If the fix is still valid, it should trigger if an application that uses
libusb uses pkg-config to find out about the necessary libs. The app
should itself not need the two libs and it should fail because of
missing symbols introduced by libusb. I think we had such a case, but
cannot remember where.

> I can find no reason to apply this patch any more, since the library
> compiles just fine without it, and even  the testtools we use
> (including libusb-compat) that use this library link just fine...
>
> If you know of a reason to keep the patch I could forward port it,
> otherwise I will update the patch to drop this patch from the tree.

For the moment, I've committed a version bump and ported the patch
forward, with a comment.

rsc
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
[email protected]

Reply via email to