Hi,
just a few comment. I didn't have the time for a more indepth review.
On Wed, Jun 23, 2010 at 12:31:59PM +0200, Carsten Schlote wrote:
> [udev] Updated to udev version 151
Don't change patches if it's not necessary. It's easier to see the real
changes that way.
> [ptxdist][v2] Updated ptxdist usage text for bash, make, removed
> autobuild
> [vpnc][v4] Added vpnc 0.5.3 package, a VPN client for Cisco
> concentrators
Do we really need the manpage patches?
> [miredo][v5] Added miredo 1.2.2, a teredo IPV6 client
It should be possible to have autogen.sh without patches.
> [ppp] Added plog and pppoe-discovery options and install
> [ppp] Updated generic/{pon|poff} to maintainer version
you could add a patch to install pon/poff. install_alternative also looks
in PKGDIR
> [mtd-utils] Fixes LZO Compression and crashes
> [nfsutils] Added dependancies when compiling NFSv4 support
> [mtd-utils] Added config options and install
please add mirgation helpers for the renamed options
> [mtd-utils] Workaround the -Werror problems
Please add a comment to the makefile to explain way CFLAGS are set.
Otherwise it could be droped as it 'works for me' without it...
> [dbench] Added dependency for libattr.so
> [sysvinit] Added comments for busybox builtins used.
If you add the comment you should also add "depends on !BUSYBOX_FOO"
> [acpid] Removed -Werror to allow compilation with GCC 4.4.1
remove "-Werror" completely. The patch header says it all.
> [dhcp] Fixed GCC 4.4.1 compile error
> [dhcp] Fixed problem with -Werror and GCC 4.5.0-snapshot
I think your second patch makes the first obsolete.
> [perl] Added version 5.10.1
mol
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
[email protected]
