Am Mittwoch, 4. August 2010, um 00:04:59 schrieb Robert Schwebel:
> On Tue, Aug 03, 2010 at 11:52:50PM +0200, Marc Kleine-Budde wrote:
> > thanks for the patch. Please explain how to get the source, maybe we can
> > figure out a nice way to automate things.
>
> git://gitorious.org/x-load-omap3/mainline.git

right, that is the source (sorry, I'm not so fast ...)

>
> > > +menuconfig X_LOAD
> > > + bool
> > > + depends on ARCH_ARM_OMAP
> > > + prompt "TI X-Loader                   "
>
> Prompt should be
>
>       prompt "x-loader                      "
>
> All menu entries are lower case. This rule does also apply to other menu
> entries.

I do so.

>
> > > +if X_LOAD
> > > +
> > > +comment "------------------------- Notice -------------------------"
> > > +comment "The X-Loader source tree was never released as download"
> > > +comment "archive. As long as that fact exists you have to store"
> > > +comment "a build tree inside your ptxdist project root at:"
> > > +comment "${PTXDIST_WORKSPACE}/local_src/x-load-${X_LOAD_VERSION}"
> > > +comment "----------------------------------------------------------"
> >
> > Where to get the sources from, then?
>
> We should bundle a packet and put it into temporary_src.

What did you mean with 'temporary_src'?
Is there any better place as the PTXdist-BSP itself (local_src)?

>
> > > +#
> > > -----------------------------------------------------------------------
> > >----- +# Get
> > > +#
> > > -----------------------------------------------------------------------
> > >----- +
> > > +$(X_LOAD_SOURCE):
> > > + @$(call targetinfo)
> > > + @$(call get, X_LOAD)
>
> The get stage should not be necessary any more in recent ptxdist.

Thank you for the hint. But I think it should be removed together with all 
other packages by a code review in the future, or not? There are many many 
make files with GET stage inside -- especially templates too.
 
>
> rsc
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


-- 
Viele Grüße,
Stephan Linz
______________________________________________________________________________
OpenDCC: http://www.li-pro.net/opendcc.phtml
PC/M: http://www.li-pro.net/pcm.phtml
CDK4AVR: http://cdk4avr.sourceforge.net/
CDK4NIOS: http://cdk4nios.sourceforge.net/
CDK4MSP: http://cdk4msp.sourceforge.net/
CPM4L: http://download.opensuse.org/repositories/home:/rexut:/CPM4L

-- 
ptxdist mailing list
[email protected]

Reply via email to