Hi,
On Wed, Feb 02, 2011 at 12:33:32PM +0100, Benoît Burnichon wrote:
> When issuing some commands from the menu, there could be error when get and
> extract steps are not already done for bootloader/kernel.
>
> That means, after a ptxdist distclean, when selecting the bootloader or
> kernel configuration, you'll end up with the following error:
>
> -----------------------------
> bash: -c: line 0: syntax error near unexpected token `;'
> bash: -c: line 0:
> `target="/home/airpad/workspace/airpad-i.MX27-2011.02.0/platform-airpad-i.MX27/state/barebox.get";
> target="${target##*/}"; dep="/home/airpad/src/barebox-2010.11.0.tar.bz2";
> dep="${dep##*/}"; echo "${target} : ${dep}" >>
> /home/airpad/workspace/airpad-i.MX27-2011.02.0/platform-airpad-i.MX27/state/depend.out;
> echo "started : ${target}" >&; target="target: ${target##*/}"; echo -e
> "\n${target//?/-}\n${target}\n${target//?/-}\n"; '
> make: ***
> [/home/airpad/workspace/airpad-i.MX27-2011.02.0/platform-airpad-i.MX27/state/barebox.get]
> Error 2
>
> ptxdist: 'barebox menuconfig' returned with an error
> ------------------------------
>
> Actually, the error is located in the following statement: echo "started:
> ${target}" >&${PTXDIST_FD_STDOUT};
>
> The init of the PTXDIST value is not performed, maybe due to a direct call to
> ptxd_make instead of ptxd_make_log which sets up the environment value.
Hmmm, this is not new with, ptxdist-2011.01.0, right? nothing changed
there. I think.
Does this help?
-------------------------------->8---------------------------------------------
diff --git a/scripts/libptxdist.sh b/scripts/libptxdist.sh
index 76c3791..b180740 100644
--- a/scripts/libptxdist.sh
+++ b/scripts/libptxdist.sh
@@ -337,6 +337,8 @@ export -f ptxd_kconfig
# ("scripts/lib/ptxd_make_"*.sh)
#
ptxd_make() {
+ export PTXDIST_FD_STDOUT="${PTXDIST_FD_STDOUT:=1}"
+ export PTXDIST_FD_STDERR="${PTXDIST_FD_STDERR:=2}"
for lib in "${SCRIPTSDIR}/lib/ptxd_make_"*.sh; do
source "${lib}" || ptxd_bailout "failed to source lib: ${lib}"
done
-------------------------------->8---------------------------------------------
It's not a real fix though. What we really want is to run most of this with
ptxd_make_log, except for the actual kernel/bootloader configuration.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
[email protected]
