Hi, On Mon, Mar 28, 2011 at 01:42:01PM +0200, Daniel Kriesten wrote: > I'm not sure if this patch is better than the previous one. I created it > using > > git format-patch --output-directory patchesX/ --signoff --patch-with-stat > --ignore-space-at-eol --ignore-space-change --ignore-all-space HEAD~5..HEAD
It applies, but now I can't really comment on it here... :-( Some notes: 1. Please add something like "Based on a patch from ..." 2. You're removing a lot of PyModule_AddIntConstant() stuff. E.g. for protocols other than CAN_RAW, why? 3. I don't think the changes in pyconfig.h.in should be part of the patch. Afaik that's generated by autoheader (called by autogen.sh). Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list [email protected]
