Hallo,

Am 12.04.2011 23:45, schrieb Michael Olbrich:
> this patch is broken. Your email probram added some line-breaks.

I assumed this would be the case. Was my first patch and I read
somewhere: just import the output of `git format-patch` to your MUA and
send it. Thunderbird seems to break it. I'll try another way next time.

>> ---
>>  rules/file.in        |   15 +++++++
>>  rules/file.make      |  102
>> ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  rules/host-file.in   |   13 ++++++
>>  rules/host-file.make |   73 +++++++++++++++++++++++++++++++++++
> 
> What's the host-file needed for?

The tool calls itself when building. If I don't have it in the cross
build environment the build fails. Just adding it as a host tool was the
easiest solution without investigating the build process and patching
it. This is definitely a cross compiler build issue.

> The "get" stage can be removed.
> I really need to update the templates for this...

That's what I did, just use the templates created and adapt the
necessary parts without removing anything else. Good to know this is
good practice.

> please remove all the stages that are commented out. They are only
> generated in case the default needs to be modified.

Will take some days, I don't know when I have time for it.

>> +# vim: ft=make noet

Because you quoted it anyway. I changed this line in the created make
files. Just changing syntax is only one aspect of make files. Resetting
expandtab (noet aka noexpandtab) is crucial because otherwise you can't
create the tab characters needed in a Makefile. But this should be issue
of another patch for the templates. ;)

Greets
Alex

-- 
»With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***

Attachment: signature.asc
Description: OpenPGP digital signature

-- 
ptxdist mailing list
[email protected]

Reply via email to