On Fri, Jun 24, 2011 at 12:19:35PM +0100, Christian Gagneraud wrote:
> Qt bindings for oFone.
> 
> Signed-off-by: Christian Gagneraud <[email protected]>
> ---
>  rules/ofono-qt.in   |   23 +++++++++++++
>  rules/ofono-qt.make |   86 
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 109 insertions(+), 0 deletions(-)
>  create mode 100644 rules/ofono-qt.in
>  create mode 100644 rules/ofono-qt.make
> 
> diff --git a/rules/ofono-qt.in b/rules/ofono-qt.in
> new file mode 100644
> index 0000000..8bc1e65
> --- /dev/null
> +++ b/rules/ofono-qt.in
> @@ -0,0 +1,23 @@
> +## SECTION=qt
> +
> +menuconfig OFONO_QT
> +       tristate
> +       prompt "ofono Qt"
> +       depends on QT4

What Qt libraries are used? You should select those too.

> +       depends on OFONO
> +       help
> +         This package contains Qt bindings to a number of oFono
> +         cellular service interfaces.
> +
> +if OFONO_QT
> +
> +config OFONO_QT_TESTS
> +       bool
> +       default n
> +       prompt "Install tests"
> +       select QT4_BUILD_QTESTLIB

use "select QT4_BUILD_QTESTLIB if OFONO_QT_TESTS" in OFONO_QT

> +       help
> +         Build and install ofono-qt testsuite.
> +
> +endif
> +
> diff --git a/rules/ofono-qt.make b/rules/ofono-qt.make
> new file mode 100644
> index 0000000..6f2a6ea
> --- /dev/null
> +++ b/rules/ofono-qt.make
> @@ -0,0 +1,86 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2009 by Christian Gagneraud <[email protected]>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_OFONO_QT) += ofono-qt
> +
> +#
> +# Paths and names
> +#
> +OFONO_QT_NAME                := ofono-qt
> +OFONO_QT_VERSION     := 0.1.2
> +OFONO_QT_MD5         := 4e528723892412f3e27b2aac3dd473af
> +OFONO_QT             := $(OFONO_QT_NAME)-$(OFONO_QT_VERSION)
> +OFONO_QT_SUFFIX              := tar.bz2
> +OFONO_QT_URL         := 
> http://api.meego.com/public/source/Trunk/libofono-qt/$(OFONO_QT).$(OFONO_QT_SUFFIX)
> +OFONO_QT_SOURCE              := $(SRCDIR)/$(OFONO_QT).$(OFONO_QT_SUFFIX)
> +OFONO_QT_DIR         := $(BUILDDIR)/$(OFONO_QT)
> +OFONO_QT_LICENSE     := ???
> +
> +# 
> ----------------------------------------------------------------------------
> +# Prepare
> +# 
> ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/ofono-qt.prepare:
> +     @$(call targetinfo)
> +     @sed -i -e 's,\[QT_INSTALL_PREFIX\],/usr,g' $(OFONO_QT_DIR)/lib/lib.pro
> +     @sed -i -e 's,\[QT_INSTALL_PREFIX\],/usr,g' 
> $(OFONO_QT_DIR)/tests/tests.pro
> +     @$(call world/prepare, OFONO_QT)
> +     @$(call touch)
> +
> +# 
> ----------------------------------------------------------------------------
> +# Compile
> +# 
> ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/ofono-qt.compile:
> +     @$(call targetinfo)
> +     @$(call compile, OFONO_QT, sub-lib-all)
> +ifdef PTXCONF_OFONO_QT_TESTS
> +     @$(call compile, OFONO_QT, sub-tests-all)
> +endif
> +     @$(call touch)

OFONO_QT_MAKE_OPT := sub-lib-all
ifdef PTXCONF_OFONO_QT_TESTS
OFONO_QT_MAKE_OPT += sub-tests-all
endif

instead.

> +
> +# 
> ----------------------------------------------------------------------------
> +# Install
> +# 
> ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/ofono-qt.install:
> +     @$(call targetinfo)
> +     @$(MAKE) -C $(OFONO_QT_DIR)/lib install INSTALL_ROOT=$(OFONO_QT_PKGDIR)
> +ifdef PTXCONF_OFONO_QT_TESTS
> +     @$(MAKE) -C $(OFONO_QT_DIR)/tests install 
> INSTALL_ROOT=$(OFONO_QT_PKGDIR)
> +endif
> +     @$(call touch)

I think

OFONO_QT_INSTALL_OPT := \
        sub-lib-all-install_subtargets \
        sub-tests-all-install_subtargets

should work. qmake should create those install target for all sub-* targets.

> +
> +# 
> ----------------------------------------------------------------------------
> +# Target-Install
> +# 
> ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/ofono-qt.targetinstall:
> +     @$(call targetinfo)
> +
> +     @$(call install_init,  ofono-qt)
> +
> +     @$(call install_fixup, ofono-qt,PRIORITY,optional)
> +     @$(call install_fixup, ofono-qt,SECTION,base)
> +     @$(call install_fixup, ofono-qt,AUTHOR,"Christian Gagneraud 
> <[email protected]>")
> +     @$(call install_fixup, ofono-qt,DESCRIPTION,Qt bindings for oFono)
> +
> +     @$(call install_lib, ofono-qt, 0, 0, 0644, libofono-qt)
> +ifdef PTXCONF_OFONO_QT_TESTS
> +#    TODO: install tests
> +endif

Please fix the TODO

Michael

> +
> +     @$(call install_finish, ofono-qt)
> +
> +     @$(call touch)
> +
> -- 
> 1.7.4.1
> 
> 
> -- 
> ptxdist mailing list
> [email protected]
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
[email protected]

Reply via email to