On Wed, Dec 14, 2011 at 12:08:28PM +0100, Marc Kleine-Budde wrote:
> On 12/14/2011 11:51 AM, Michael Olbrich wrote:
> > On Wed, Dec 14, 2011 at 12:06:59AM +0100, Andreas Bießmann wrote:
> >> Using /bin/sh in setlocalversion lead to corrupted $PTXDIST_VERSION_FULL
> >> cause the 'echo -n "$v"' will use the builtin echo which does not know
> >> about -n switch.
> > 
> > Hmmm, I think we could just drop the '-n'.
> > 
> > Marc: this is your code, what do you think.
> 
> We could use printf instead. I'm not sure what happens, when we have a
> trailing newline in the version information.

It's used in '$()' which should remove the newline.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
[email protected]

Reply via email to